Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: some more refactoring in JsonRpcValidator #1750

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Jan 11, 2024

No description provided.

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jan 11, 2024
@canepat canepat marked this pull request as draft January 11, 2024 12:09
@canepat canepat force-pushed the ci/rpcdaemon_more_refactoring_jsonrpcvalidator branch from a604460 to 5d347ba Compare January 11, 2024 14:24
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (051773f) 52.72% compared to head (5d347ba) 52.74%.

Files Patch % Lines
silkworm/rpc/http/json_rpc_validator.cpp 67.39% 24 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
+ Coverage   52.72%   52.74%   +0.02%     
==========================================
  Files         599      599              
  Lines       44770    44770              
  Branches     6946     6947       +1     
==========================================
+ Hits        23605    23614       +9     
+ Misses      19103    19090      -13     
- Partials     2062     2066       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat marked this pull request as ready for review January 11, 2024 15:06
@canepat canepat merged commit 346ed4c into master Jan 11, 2024
13 checks passed
@canepat canepat deleted the ci/rpcdaemon_more_refactoring_jsonrpcvalidator branch January 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants