Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address cert-oop54-cpp & concurrency-mt-unsafe warnings #1759

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Conversation

yperbasis
Copy link
Member

No description provided.

@yperbasis yperbasis added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jan 17, 2024
@yperbasis yperbasis marked this pull request as ready for review January 17, 2024 10:42
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d6d3d8a) 52.98% compared to head (65494de) 52.99%.
Report is 1 commits behind head on master.

Files Patch % Lines
silkworm/node/etl/file_provider.cpp 0.00% 4 Missing ⚠️
silkworm/core/common/small_map.hpp 0.00% 2 Missing and 1 partial ⚠️
silkworm/core/concurrency/resettable_once_flag.hpp 0.00% 2 Missing and 1 partial ⚠️
silkworm/infra/common/memory_mapped_file.cpp 25.00% 3 Missing ⚠️
silkworm/node/bittorrent/client.cpp 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
+ Coverage   52.98%   52.99%   +0.01%     
==========================================
  Files         599      599              
  Lines       44784    44793       +9     
  Branches     6958     6961       +3     
==========================================
+ Hits        23728    23740      +12     
+ Misses      18973    18968       -5     
- Partials     2083     2085       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat merged commit 4b428d7 into master Jan 17, 2024
13 of 14 checks passed
@canepat canepat deleted the ci/tidier10 branch January 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants