rpcdaemon: add support for rotating log files of external interfaces #1784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new abstraction to produce rotating log files tailored for external interfaces (e.g. JSON-RPC API), which means logging incoming requests and outgoing responses, possibly filtered according to some application-level need (e.g. slow latency request/response, whatever slow means depending on the context). The proposed implementation relies on usage of spdlog, choosing the best performance-wise library is left as a further optimisation, if proven necessary.
The foreseen usages are:
This PR doesn't introduce any activation or usage of the feature yet.
Moreover, the following minor changes are added: