core, rpcdaemon: unify ExecutionProcessor and EVMExecutor #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzawisto
force-pushed
the
2304-deduplicate-code-in-rpcevmexecutor-and-executionprocessor
branch
from
da0dc1a
to
95e8c9c
Compare
JacekGlen
changed the title
canepat
approved these changes
Oct 4, 2024
| @@ -53,6 +55,8 @@ class ExecutionProcessor { | |||
|
|
|||
| EVM& evm() noexcept { return evm_; } | |||
| const EVM& evm() const noexcept { return evm_; } | |||
| IntraBlockState& get_ibs_state() { return state_; } | |||
| void reset(); | |||
There was a problem hiding this comment.
Some nitpicking here:
- we should rename
get_ibs_stateasintra_block_stateboth here and inEVMExecutor - given that
IntraBlockStateis already exported, maybe it's better to avoidresetaltogether and just callintra_block_state().clear_journal_and_substate()
None of these changes is necessary in this PR.
canepat
added
the
maintenance
canepat
changed the title
canepat
deleted the
2304-deduplicate-code-in-rpcevmexecutor-and-executionprocessor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies (to some extent) the code that was duplicated in
EVMExecutorandExecutionProcessor. Some bits still require different implementation, but at least the logic is kept in a single place (in bothvalidation.cppandprocessor.cpp). Two tests have to be updated due to slightly different access pattern for retrieving balance.