Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: enforce parameter case #2583

Merged
merged 6 commits into from
Jan 23, 2025
Merged

clang-tidy: enforce parameter case #2583

merged 6 commits into from
Jan 23, 2025

Conversation

yperbasis
Copy link
Member

No description provided.

@yperbasis yperbasis added the maintenance Some maintenance work (fix, refactor, rename, test...) label Dec 11, 2024
@yperbasis yperbasis marked this pull request as draft December 11, 2024 20:33
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.46%. Comparing base (5dfedae) to head (e50f501).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
silkworm/node/stagedsync/forks/fork.cpp 0.00% 2 Missing ⚠️
silkworm/rpc/commands/ots_api.cpp 0.00% 2 Missing ⚠️
silkworm/rpc/engine/remote_execution_engine.cpp 0.00% 1 Missing ⚠️
silkworm/sync/sync_pos.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2583   +/-   ##
=======================================
  Coverage   50.46%   50.46%           
=======================================
  Files         803      803           
  Lines       52873    52873           
  Branches     8218     8218           
=======================================
+ Hits        26680    26681    +1     
+ Misses      23862    23858    -4     
- Partials     2331     2334    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yperbasis yperbasis marked this pull request as ready for review January 22, 2025 16:11
@canepat canepat merged commit c778f92 into master Jan 23, 2025
17 checks passed
@canepat canepat deleted the ci/tidier29 branch January 23, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants