Skip to content

Commit

Permalink
Improve Linter
Browse files Browse the repository at this point in the history
* linter for pr, which only lints new and edited files
* linter for whole code base, representing the current linting
  state of the project
* use the same base settings (enabled/disabled linters) for both
  jobs
  • Loading branch information
xx4h committed Apr 13, 2024
1 parent 0ef9f83 commit ffd16ed
Showing 1 changed file with 32 additions and 12 deletions.
44 changes: 32 additions & 12 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,23 @@ on:
workflow_dispatch:
push:
branches: main
paths-ignore:
- '**/*.md'
pull_request:
branches: main
paths-ignore:
- '**/*.md'

env:
VALIDATE_BASH_EXEC: false
VALIDATE_CPP: false
VALIDATE_CLANG_FORMAT: false
VALIDATE_SHELL_SHFMT: false
VALIDATE_PYTHON_PYLINT: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

permissions: { }

jobs:
build:
name: Lint Code Base
lint_pr:
name: Lint Pull Request
if: ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -33,9 +38,24 @@ jobs:
env:
# only validate new or edited files
VALIDATE_ALL_CODEBASE: false
VALIDATE_BASH_EXEC: false
VALIDATE_CPP: false
VALIDATE_CLANG_FORMAT: false
VALIDATE_SHELL_SHFMT: false
VALIDATE_PYTHON_PYLINT: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

lint_code_base:
name: Lint Code Base
if: ${{ github.event_name == 'push' }}
runs-on: ubuntu-latest
permissions:
contents: read
packages: read
# To report github actions status checks
statuses: write
steps:
- name: Checkout Code
uses: actions/checkout@v4
with:
# Full git history is needed to get a proper list of changed files within `super-linter`
fetch-depth: 0
- name: Lint Code Base
uses: super-linter/[email protected]
env:
# validate the whole code base
VALIDATE_ALL_CODEBASE: true

0 comments on commit ffd16ed

Please sign in to comment.