Fix duplicate C++ ctor/dtor entries with --demangle. #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, gcc seems to emit multiple symbols for ctors and dtors. This seems to be in adherence with the specification of the Itanium C++ ABI. A pretty good description of the issue can be found here .
However,
c++filt
generates the same demangled names for these symbols. Apparently, this was not always the case. Since demangling is currently done after reading thelcov
files, this results in duplicate entries in the output XML file.According to the Cobertura DTD, each
class
should only have a singlemethod
entry. This can lead to issues with certain parsers. For example, the Jenkins Coverage plugin will not accept XML files with duplicate method entries for the same class.This PR resolves the issue by applying the demangling operation when the function hit data is stored, and summing the hit counts as needed.