Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine LTS builds for OTP 23 and 24 #336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fholzhauser
Copy link

With alpine 3.13, the updated kernel headers break SCTP support when the image runs on a host with < 5.5 kernel versions.
To keep SCTP working and benefit from the improvements on alpine 3.13 (e.g. the new musl library), this PR adds alpine-lts image variants using 5.4 kernel headers for building OTP 23 and 24.
This is only useful/necessary until the commonly used LTS distributions on container hosts catch up to kernel version 5.5 or above and for deployments using SCTP.
Would you consider this change to address issue #332 ?

With alpine 3.13, the updated kernel headers break SCTP support
when the images are running on a host with < 5.5 kernel versions.
However the updates in alpine 3.13 have positive impact on memory
management and performance.
To keep SCTP working and benefit from the improvements on
alpine 3.13, this commit adds alpine-lts images that use 5.4 kernel
headers for building erlang OTP version 23 and 24.
@vkatsuba
Copy link
Contributor

vkatsuba commented May 6, 2021

@fholzhauser could you please rebase PR with master and add 'DIR=24 VARIANT=alpine-lts', 'DIR=23 VARIANT=alpine-lts' section https://github.com/erlang/docker-erlang-otp/blob/master/.github/workflows/erlang.yaml#L10.

@vkatsuba
Copy link
Contributor

Hi All,

Any updates about this PR?

Regards,
--V

@vkatsuba
Copy link
Contributor

Hi @getong, could you please take a look to this PR? Many thanks fr your time.

Regards,
--V

@getong
Copy link
Collaborator

getong commented May 28, 2021

I know this issue, but why choose alpine:3.13 as the LTS version, I am not sure why choose this version as the LTS version.
Need more information.
Besides, the pr should be rebase to current master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants