Skip to content

Conversation

u3s
Copy link
Contributor

@u3s u3s commented Sep 19, 2025

  • explicit exports
  • unused code commented out

- explicit exports
- unused code commented out
@u3s u3s self-assigned this Sep 19, 2025
@u3s u3s added the team:PS Assigned to OTP team PS label Sep 19, 2025
Copy link
Contributor

github-actions bot commented Sep 19, 2025

CT Test Results

    2 files     29 suites   18m 48s ⏱️
  481 tests   475 ✅  6 💤 0 ❌
1 686 runs  1 660 ✅ 26 💤 0 ❌

Results for commit cd2cf74.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Sep 19, 2025
@u3s u3s requested review from IngelaAndin and removed request for IngelaAndin September 19, 2025 12:23
@IngelaAndin
Copy link
Contributor

I think either the commented code should be removed as it is not needed or we should extend the code somehow so that it is used for something.

@u3s
Copy link
Contributor Author

u3s commented Sep 23, 2025

Yes. I agree, then let's leave this PR for a while. I can convert it into draft.

@u3s u3s marked this pull request as draft September 23, 2025 11:52
@u3s u3s removed the testing currently being tested, tag is used by OTP internal CI label Sep 25, 2025
@juhlig
Copy link
Contributor

juhlig commented Sep 29, 2025

In a past PR, @bjorng said that PropEr is the exclusive property testing tool used in OTP (see #7364 (comment)). Thus, I think the parts relating to EQC should be removed, starting with the file names (*_eqc_*), but also the -ifndef(PROPER). directives etc.

@IngelaAndin
Copy link
Contributor

@juhlig this used to be true, but that is about to change. Although it is at the moment unclear if all will property test will run on github. This is a work in progress so I do not want to get ahead of things. I think that the current code was QuicCheck tests that where later was sort of ported to proper in an not optimal way. That is why this is now in Draft and we will get back to it later.

@IngelaAndin IngelaAndin added the stalled waiting for input by the Erlang/OTP team label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled waiting for input by the Erlang/OTP team team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants