-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(kernel): fix typos #8927
base: master
Are you sure you want to change the base?
chore(kernel): fix typos #8927
Conversation
Cleanup typographic errors in `kernel` code. Not all errors are yet cleaned up, as it requires some additional considerations.
CT Test Results 2 files 69 suites 1h 5m 3s ⏱️ For more details on these failures, see this check. Results for commit 271dd70. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm not sure that we should change misspelled atoms exposed in public interfaces -- a test case failed because of this and it's possible (albeit very unlikely) that some user might've expected the same. Can we split this into one commit for comments and documentation, and another for code?
As an aside, please change the commit format to kernel: Fix typos
. We don't use chore(...)
or feat(...)
. :-)
@@ -310,7 +310,7 @@ handler_loop(Sock, {select_info, recv, SelectHandle}) -> | |||
end; | |||
|
|||
%% This is the (asyncronous) behaviour on platforms that support 'completion', | |||
%% currently only Windows. | |||
%% currently onla Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%% currently onla Windows. | |
%% currently only Windows. |
@@ -476,7 +476,7 @@ <H3> THE FUTURE</H3> | |||
will be Real Programmers willing to jump in and Solve The Problem, | |||
saving the documentation for later. Long live FORTRAN! <P> | |||
|
|||
<H3>ACKNOWLEGEMENT</H3> | |||
<H3>ACKNOWLEDGEMENT</H3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pre-existing document included as test data, let's skip this one.
Yeah, I forgot about naming scheme and I do not think that it is in |
There is a link in |
Cleanup typographic errors in
kernel
code.Not all errors are yet cleaned up, as it requires some additional
considerations.