dgud/ssl/add ets tab to socket #9019
Conversation
dgud
added
team:PS
CT Test Results 2 files 66 suites 46m 49s ⏱️ Results for commit 6fe0de9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
dgud
force-pushed
the
dgud/ssl/add-ets-tab-to-socket
branch
from
a1ac0c0
to
89299c5
Compare
There was a problem hiding this comment.
I think the individual changes looks good. As we discussed yesterday I feel that it would be beneficial to make two PRs. One for optimizing away reconstruction of TLS socket and making it part of the static state information. And one for using ets-table and moving packet option handling. So the first is something that is clearly beneficial and something we are sure that we want to do. And the other approach is more under evolution and we like to try and build on it, and it would be easier to revert if it is separate and we decide to go some other way.
dgud
force-pushed
the
dgud/ssl/add-ets-tab-to-socket
branch
from
89299c5
to
dc177b9
Compare
|
Split into 2 commits and added some log improvements from another branch. |
dgud
force-pushed
the
dgud/ssl/add-ets-tab-to-socket
branch
from
dc177b9
to
b643f35
Compare
|
Added a test fixup commit as well, which have bothered me for a long time. |
|
We could clarify the commit message for the ets table commit, as the ets table is not common between tls client and tls server processes but rather by the user process and the tls process. |
So we don't need to recreate it every time in the hot path, also simplifies the code, reduces the number of arguments to many functions.
And move packet encoding to user process. Socket options like packet-mode must be accessable from both user and ssl-processes. But we could move more stuff to that table to minimize the process state.
Reduce the output of (almost) every testcase output, by putting some settings in fun(). This is just done to reduce the printing of `=== Config value: ....` That is printed in each testcase and could be up to 2000 lines.
dgud
force-pushed
the
dgud/ssl/add-ets-tab-to-socket
branch
from
6fe0de9
to
e2ae5b5
Compare
Will be needed in future optimizations.
Also a base to move stuff to an ets table instead of keeping them in process state.