EEP 78: Multi-valued comprehensions #9374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 419 suites 1h 14m 0s ⏱️ Results for commit cd1e028. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
michalmuskala
force-pushed
the
multi-comprehensions
branch
from
1531a18 to
2fc00d6
Compare
This required relaxing the parsing rules of map comprehensions from map_field_assoc to just map_field. The check that map comprehensions only contain map_field_assoc entries will be reproduced in erl_lint in a subsequent commit.
michalmuskala
force-pushed
the
multi-comprehensions
branch
from
2fc00d6 to
0f9ca60
Compare
michalmuskala
force-pushed
the
multi-comprehensions
branch
from
0f9ca60 to
cd1e028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR implementing proposal from erlang/eep#75