Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAPI 2.0 Compliance #19

Merged
merged 1 commit into from
Apr 30, 2024
Merged

FAPI 2.0 Compliance #19

merged 1 commit into from
Apr 30, 2024

Conversation

maennchen
Copy link
Member

No description provided.

@maennchen maennchen added the enhancement New feature or request label Apr 30, 2024
@maennchen maennchen self-assigned this Apr 30, 2024
@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 593155141feefe7c21d4cd615c02319254bacf16-PR-19

Details

  • 26 of 29 (89.66%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.1%) to 97.857%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/oidcc/plug/authorization_callback.ex 18 21 85.71%
Totals Coverage Status
Change from base Build 2275f7f32718ba03ea421ca6a649809647beb0a0: -2.1%
Covered Lines: 137
Relevant Lines: 140
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 520d4a1746fda982822cb16a008b678abd43abed-PR-19

Details

  • 6 of 21 (28.57%) changed or added relevant lines in 2 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-28.1%) to 71.852%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/oidcc/plug/authorize.ex 3 8 37.5%
lib/oidcc/plug/authorization_callback.ex 3 13 23.08%
Files with Coverage Reduction New Missed Lines %
lib/oidcc/plug/authorization_callback.ex 23 34.0%
Totals Coverage Status
Change from base Build 2275f7f32718ba03ea421ca6a649809647beb0a0: -28.1%
Covered Lines: 97
Relevant Lines: 135
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 520d4a1746fda982822cb16a008b678abd43abed-PR-19

Details

  • 6 of 21 (28.57%) changed or added relevant lines in 2 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-28.1%) to 71.852%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/oidcc/plug/authorize.ex 3 8 37.5%
lib/oidcc/plug/authorization_callback.ex 3 13 23.08%
Files with Coverage Reduction New Missed Lines %
lib/oidcc/plug/authorization_callback.ex 23 34.0%
Totals Coverage Status
Change from base Build 2275f7f32718ba03ea421ca6a649809647beb0a0: -28.1%
Covered Lines: 97
Relevant Lines: 135
💛 - Coveralls

@maennchen maennchen marked this pull request as ready for review April 30, 2024 14:41
@maennchen maennchen merged commit e577ae7 into main Apr 30, 2024
13 checks passed
@maennchen maennchen deleted the fapi branch April 30, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maennchen maennchen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maennchen @coveralls