Implement (very basic) first version #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. renames input-1 as elp-version and drops outputs 2. tests with the help of erlef/setup-beam: both test and action 3. implements basic understanding of arch.s and platforms 4. installs ELP and caches it as a tool 5. outputs the result of `elp version` when installed 6. fetches Erlang version from running system (using -eval)
|
|
||
| - name: Output input-1 (from output-1) | ||
| run: echo "${{ steps.setup-elp.outputs.output-1 }}" | ||
| - run: elp version |
There was a problem hiding this comment.
If this works, it means installation for ELP for the arch + platform + OTP (derived from the erl execution) went Ok
README.md
Outdated
There was a problem hiding this comment.
Doesn't need to be complete, at the moment; it's just a better draft than what we had.
There was a problem hiding this comment.
Not close to complete, but a very basic working version (locally everything passes until I reach elp version - I believe it's because I'm downloading for ARM, but the executable is AMD)
src/setup-elp.js
Outdated
|
|
||
| const runnerToolPath = path.join(process.env.RUNNER_TEMP, '.setup-elp', 'elp') | ||
| fs.cpSync(cachePath, runnerToolPath, { recursive: true }) | ||
| fs.chmodSync(path.join(runnerToolPath, 'elp'), 0o755) |
There was a problem hiding this comment.
Not sure why this is required. Doing a regular download (wget + tar zx) fetches the proper attributes.
We also do some pretty'ing for readability (hopefully!)
We were caching a file, not a folder, and then that file (unextracted) is the one that was being copied for use
paulo-ferraz-oliveira
force-pushed
the
feature/very-basic-first-version
branch
from
b1d5190 to
f60191b
Compare
... so we turn YYYY-MM-DD_N into YYYY.MM.DD+N
paulo-ferraz-oliveira
force-pushed
the
feature/very-basic-first-version
branch
from
7b2b416 to
8a11f0a
Compare
Comment on lines
+43
to
+46
| function semverFromELPVersion(elpVersion) { | ||
| let [major, minor, patch, build] = elpVersion.split(/[-_]/).slice(0, 4) | ||
| return `${Number(major)}.${Number(minor)}.${Number(patch)}+${Number(build) || 1}` | ||
| } |
There was a problem hiding this comment.
An important element...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a step in the next direction 😄
input-1aselp-versionand drops outputserlef/setup-beam: both npm test and the action itselfelp versionwhen installed