set dist_listen to false for command that grabs the hostname #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without dist_listen set to false this command will try to bind to a listen port which will fail if epmd isn't being started. There is no need to set a port for it to listen on since it is only there to get the hostname.
|
Not sure if it is worth getting rid of this call altogether if running on 23.1+, but maybe? I noted the fact we probably can in this issue #811 |
ferd
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without dist_listen set to false this command will try to bind to
a listen port which will fail if epmd isn't being started. There
is no need to set a port for it to listen on since it is only
there to get the hostname.