Eliminate use of experimental function code:lib_dir/2 #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `code:lib_dir/2` function was introduced to support looking into archives. Both archives and the `code:lib_dir/2` are marked as experimental. In the upcoming Erlang/OTP 27 release, `code:lib_dir/2` will be deprecated. In some future release, the archive functionality will be changed (`escript:extract/2` will continue to work, reading archive members using `erl_prim_loader` will not).
|
Should absolutely be safe for relx as far as I can tell, and I think the CI checks are unrelated. |
ferd
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
code:lib_dir/2function was introduced to support looking into archives. Both archives and thecode:lib_dir/2are marked as experimental.In the upcoming Erlang/OTP 27 release,
code:lib_dir/2will be deprecated. In some future release, the archive functionality will be changed (escript:extract/2will continue to work, reading archive members usingerl_prim_loaderwill not).