This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
resolve several issues found by cppcheck #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[servers/slapd/slapi/slapi_overlay.c:48] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb. [servers/slapd/slapi/slapi_overlay.c:49] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb. [servers/slapd/slapi/slapi_overlay.c:50] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb. [servers/slapd/slapi/slapi_overlay.c:51] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb. [libraries/libreldap/ntlm.c:104] -> [libraries/libreldap/ntlm.c:107]: (warning) Either the condition 'ld==NULL' is redundant or there is possible null pointer dereference: ld.
[libraries/libreldap/sortctrl.c:282] -> [libraries/libreldap/sortctrl.c:284]: (warning) Either the condition 'ld==NULL' is redundant or there is possible null pointer dereference: ld. [libraries/libreldap/sortctrl.c:399] -> [libraries/libreldap/sortctrl.c:401]: (warning) Either the condition 'ld==NULL' is redundant or there is possible null pointer dereference: ld. [libraries/libreldap/sortctrl.c:482] -> [libraries/libreldap/sortctrl.c:484]: (warning) Either the condition 'ld==NULL' is redundant or there is possible null pointer dereference: ld.
|
Thanks. |
erthink
reviewed
Aug 20, 2017
| @@ -45,13 +45,12 @@ slapi_over_pblock_new( Operation *op, SlapReply *rs ) | |||
| Slapi_PBlock *pb; | |||
|
|
|||
| pb = slapi_pblock_new(); | |||
| PBLOCK_ASSERT_OP( pb, op->o_tag ); | |||
There was a problem hiding this comment.
Oops, this is wrong: assert(pb->pb_op != NULL);
erthink
reviewed
Aug 20, 2017
| if ( ld == NULL || res == NULL ) { | ||
| return LDAP_PARAM_ERROR; | ||
| } | ||
|
|
||
| assert( ld != NULL ); |
There was a problem hiding this comment.
This asserts should check precondition, but are useless after prev checks.
|
Invalid, should be reverted. |
erthink
reviewed
Aug 20, 2017
|
|
||
| if ( ld == NULL ) return LDAP_PARAM_ERROR; | ||
|
|
||
| assert( LDAP_VALID( ld ) ); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[servers/slapd/slapi/slapi_overlay.c:48] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb.
[servers/slapd/slapi/slapi_overlay.c:49] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb.
[servers/slapd/slapi/slapi_overlay.c:50] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb.
[servers/slapd/slapi/slapi_overlay.c:51] -> [servers/slapd/slapi/slapi_overlay.c:53]: (warning) Either the condition '(pb)!=NULL' is redundant or there is possible null pointer dereference: pb.
[libraries/libreldap/ntlm.c:104] -> [libraries/libreldap/ntlm.c:107]: (warning) Either the condition 'ld==NULL' is redundant or there is possible null pointer dereference: ld.