Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build fails #677

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Docker build fails #677

merged 1 commit into from
Feb 8, 2025

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Feb 2, 2025

Describe the bug
Docker build commands fails

To Reproduce
Steps to reproduce the behaviour:
I went to this folder:
cd SaltGUI/docker/dockerfiles
and ran:
docker build -f dockerfile-saltmaster --tag erwindon/saltgui-saltmaster:3007.1 .
and got this error:
=> ERROR [ 5/12] RUN curl -fsSL -o /etc/apt/keyrings/salt-archive-keyring-2023.gpg https://repo.saltproject.io/salt/py3/ubuntu/22.04/amd64/SALT-PROJECT-G 0.8s

Expected behaviour
successful build

Additional context
I think the reason for failure is the repo.saltproject.io domain does no longer exist and has migrated to packages.broadcom.com

related link:
https://saltproject.io/blog/salt-project-package-repo-migration-and-guidance/

@erwindon
Copy link
Owner

erwindon commented Feb 1, 2025

I'll update this (later).
Coincidentally, I started migrating the SaltGUI test-lab (which is not on GitHub) just a few days ago.
I'm now working on the following migrations, sequentially:

  1. SaltStack 3006/3007 versions (update: done)
    using packages.broadcom.com
  2. older SaltStack versions
    using archive.repo.saltproject.io.turtletraction.com (update: never mind, that archive is incomplete)
  3. unsupporting any now missing SaltStack versions
    e.g. from 3000-3005 or from 2014-2019 or even from 0.6-0.17 (update: now unsupporting all of these)
  4. the docker-testset in the SaltGui repo (as also raised in this ticket)
  5. any other details in the SaltGui repo (update: did not find anything else)

@erwindon
Copy link
Owner

erwindon commented Feb 2, 2025

several files to be updated:

  • docker/README.md
  • docker/dockerfiles/dockerfile-saltminion-debian
  • docker/dockerfiles/dockerfile-saltminion-ubuntu
  • docker/dockerfiles/dockerfile-saltminion-centos
  • docker/dockerfiles/dockerfile-saltmaster

Copy link

sonarqubecloud bot commented Feb 2, 2025

@erwindon
Copy link
Owner

erwindon commented Feb 2, 2025

@MrSmiler
I've converted this issue into a PR, based on changes in a new branch that I created.
The dockerfiles in this branch are updated.
The resulting docker images have been uploaded to docker-hub.
Can you please review the changes before I merge them?

@erwindon erwindon requested a review from MrSmiler February 2, 2025 23:43
@erwindon erwindon assigned MrSmiler and unassigned erwindon Feb 2, 2025
@erwindon
Copy link
Owner

erwindon commented Feb 7, 2025

@MrSmiler
do you have the opportunity to look at this PR?

Copy link

@MrSmiler MrSmiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and built the docker files, everything is good

@erwindon erwindon merged commit 2672556 into master Feb 8, 2025
5 checks passed
@erwindon erwindon deleted the update_docker branch February 8, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants