Merge pull request #93 from es-tooling/assignless

feat: add object.assign codemod

codemods/object.assign/index.js

@@ -0,0 +1,38 @@
+import jscodeshift from 'jscodeshift';
+import { removeImport } from '../shared.js';
+
+/**
+ * @typedef {import('../../types.js').Codemod} Codemod
+ * @typedef {import('../../types.js').CodemodOptions} CodemodOptions
+ */
+
+/**
+ * @param {CodemodOptions} [options]
+ * @returns {Codemod}
+ */
+export default function (options) {
+	return {
+		name: 'object.assign',
+		transform: ({ file }) => {
+			const j = jscodeshift;
+			const root = j(file.source);
+
+			const { identifier } = removeImport('object.assign', root, j);
+
+			root
+				.find(j.CallExpression, {
+					callee: {
+						name: identifier,
+					},
+				})
+				.replaceWith(({ node }) => {
+					return j.callExpression(
+						j.memberExpression(j.identifier('Object'), j.identifier('assign')),
+						node.arguments,
+					);
+				});
+
+			return root.toSource(options);
+		},
+	};
+}

codemods/shared.js

@@ -21,8 +21,8 @@ export function removeImport(name, root, j) {
 		},
 	});
 
-	const requireDeclaration = root.find(j.VariableDeclarator, {
-		init: {
+	const requireDeclaration = root
+		.find(j.CallExpression, {
 			callee: {
 				name: 'require',
 			},
@@ -31,8 +31,8 @@ export function removeImport(name, root, j) {
 					value: name,
 				},
 			],
-		},
-	});
+		})
+		.closest(j.VariableDeclarator);
 
 	// Require statements without declarations like `Object.is = require("object-is");`
 	const requireAssignment = root.find(j.AssignmentExpression, {

index.js

@@ -109,6 +109,7 @@ import numberPrototypeToexponential from './codemods/number.prototype.toexponent
 import objectAssign from './codemods/object-assign/index.js';
 import objectIs from './codemods/object-is/index.js';
 import objectKeys from './codemods/object-keys/index.js';
+import objectAssign2 from './codemods/object.assign/index.js';
 import objectDefineproperties from './codemods/object.defineproperties/index.js';
 import objectEntries from './codemods/object.entries/index.js';
 import objectFromentries from './codemods/object.fromentries/index.js';
@@ -274,6 +275,7 @@ export const codemods = {
   "object-assign": objectAssign,
   "object-is": objectIs,
   "object-keys": objectKeys,
+  "object.assign": objectAssign2,
   "object.defineproperties": objectDefineproperties,
   "object.entries": objectEntries,
   "object.fromentries": objectFromentries,

test/fixtures/object.assign/get-polyfill/after.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/get-polyfill/before.js

@@ -0,0 +1,10 @@
+const assign = require('object.assign').getPolyfill();
+
+assign({}, {foo: 303}, {bar: 808});
+
+assign({}, {});
+
+const foo = {};
+const bar = {};
+
+assign(foo, bar);

test/fixtures/object.assign/get-polyfill/result.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/shim/after.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/shim/before.js

@@ -0,0 +1,10 @@
+const assign = require('object.assign').shim();
+
+assign({}, {foo: 303}, {bar: 808});
+
+assign({}, {});
+
+const foo = {};
+const bar = {};
+
+assign(foo, bar);

test/fixtures/object.assign/shim/result.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/simple-cjs/after.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/simple-cjs/before.js

@@ -0,0 +1,10 @@
+const assign = require('object.assign');
+
+assign({}, {foo: 303}, {bar: 808});
+
+assign({}, {});
+
+const foo = {};
+const bar = {};
+
+assign(foo, bar);

test/fixtures/object.assign/simple-cjs/result.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/simple/after.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

test/fixtures/object.assign/simple/before.js

@@ -0,0 +1,10 @@
+import assign from 'object.assign';
+
+assign({}, {foo: 303}, {bar: 808});
+
+assign({}, {});
+
+const foo = {};
+const bar = {};
+
+assign(foo, bar);

test/fixtures/object.assign/simple/result.js

@@ -0,0 +1,8 @@
+Object.assign({}, {foo: 303}, {bar: 808});
+
+Object.assign({}, {});
+
+const foo = {};
+const bar = {};
+
+Object.assign(foo, bar);

types/codemods/object.assign/index.d.ts

@@ -0,0 +1,11 @@
+/**
+ * @typedef {import('../../types.js').Codemod} Codemod
+ * @typedef {import('../../types.js').CodemodOptions} CodemodOptions
+ */
+/**
+ * @param {CodemodOptions} [options]
+ * @returns {Codemod}
+ */
+export default function _default(options?: import("../../types.js").CodemodOptions | undefined): Codemod;
+export type Codemod = import("../../types.js").Codemod;
+export type CodemodOptions = import("../../types.js").CodemodOptions;