-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
8 changed files
with
187 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import jscodeshift from 'jscodeshift'; | ||
import { removeImport } from '../shared.js'; | ||
|
||
/** | ||
* @typedef {import('../../types.js').Codemod} Codemod | ||
* @typedef {import('../../types.js').CodemodOptions} CodemodOptions | ||
*/ | ||
|
||
/** | ||
* @param {CodemodOptions} [options] | ||
* @returns {Codemod} | ||
*/ | ||
export default function (options) { | ||
return { | ||
name: 'is-string', | ||
transform: ({ file }) => { | ||
const j = jscodeshift; | ||
const root = j(file.source); | ||
|
||
removeImport('is-string', root, j); | ||
|
||
// Replace all calls to isString with Object.prototype.toString.call | ||
root | ||
.find(j.CallExpression, { | ||
callee: { | ||
type: 'Identifier', | ||
name: 'isString', | ||
}, | ||
}) | ||
.replaceWith((path) => { | ||
const arg = path.node.arguments[0]; | ||
return j.callExpression( | ||
j.memberExpression( | ||
j.memberExpression( | ||
j.memberExpression( | ||
j.identifier('Object'), | ||
j.identifier('prototype'), | ||
), | ||
j.identifier('toString'), | ||
), | ||
j.identifier('call'), | ||
), | ||
[arg], | ||
); | ||
}) | ||
.forEach((path) => { | ||
const parent = path.parent.node; | ||
if (j.BinaryExpression.check(parent)) { | ||
parent.operator = '==='; | ||
parent.right = j.literal('[object String]'); | ||
} else if ( | ||
j.CallExpression.check(parent) && | ||
parent.arguments.length === 1 | ||
) { | ||
const newExpression = j.binaryExpression( | ||
'===', | ||
path.node, | ||
j.literal('[object String]'), | ||
); | ||
parent.arguments[0] = newExpression; | ||
} | ||
}); | ||
|
||
return root.toSource({ quote: 'single' }); | ||
}, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
var assert = require('assert'); | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(42) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(NaN) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(Infinity) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Number(42)) === '[object String]'); | ||
|
||
assert.ok(Object.prototype.toString.call('foo') === '[object String]'); | ||
assert.ok(Object.prototype.toString.call(Object('foo')) === '[object String]'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
var isString = require('is-string'); | ||
var assert = require('assert'); | ||
|
||
assert.notOk(isString(undefined)); | ||
assert.notOk(isString(null)); | ||
assert.notOk(isString(false)); | ||
assert.notOk(isString(true)); | ||
assert.notOk(isString(function () {})); | ||
assert.notOk(isString([])); | ||
assert.notOk(isString({})); | ||
assert.notOk(isString(/a/g)); | ||
assert.notOk(isString(new RegExp('a', 'g'))); | ||
assert.notOk(isString(new Date())); | ||
assert.notOk(isString(42)); | ||
assert.notOk(isString(NaN)); | ||
assert.notOk(isString(Infinity)); | ||
assert.notOk(isString(new Number(42))); | ||
|
||
assert.ok(isString('foo')); | ||
assert.ok(isString(Object('foo'))); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
var assert = require('assert'); | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(42) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(NaN) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(Infinity) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Number(42)) === '[object String]'); | ||
|
||
assert.ok(Object.prototype.toString.call('foo') === '[object String]'); | ||
assert.ok(Object.prototype.toString.call(Object('foo')) === '[object String]'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import assert from 'assert'; | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(42) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(NaN) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(Infinity) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Number(42)) === '[object String]'); | ||
|
||
assert.ok(Object.prototype.toString.call('foo') === '[object String]'); | ||
assert.ok(Object.prototype.toString.call(Object('foo')) === '[object String]'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import assert from 'assert'; | ||
import isString from 'is-string'; | ||
|
||
assert.notOk(isString(undefined)); | ||
assert.notOk(isString(null)); | ||
assert.notOk(isString(false)); | ||
assert.notOk(isString(true)); | ||
assert.notOk(isString(function () {})); | ||
assert.notOk(isString([])); | ||
assert.notOk(isString({})); | ||
assert.notOk(isString(/a/g)); | ||
assert.notOk(isString(new RegExp('a', 'g'))); | ||
assert.notOk(isString(new Date())); | ||
assert.notOk(isString(42)); | ||
assert.notOk(isString(NaN)); | ||
assert.notOk(isString(Infinity)); | ||
assert.notOk(isString(new Number(42))); | ||
|
||
assert.ok(isString('foo')); | ||
assert.ok(isString(Object('foo'))); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import assert from 'assert'; | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(42) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(NaN) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(Infinity) === '[object String]'); | ||
assert.notOk(Object.prototype.toString.call(new Number(42)) === '[object String]'); | ||
|
||
assert.ok(Object.prototype.toString.call('foo') === '[object String]'); | ||
assert.ok(Object.prototype.toString.call(Object('foo')) === '[object String]'); |