Add codemod to replace object-keys
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepassle
reviewed
Jul 18, 2024
codemods/object-keys/index.js
Outdated
| @@ -1,5 +1,6 @@ | |||
| import jscodeshift from "jscodeshift"; | |||
| import { removeImport } from "../shared.js"; | |||
| import { log } from "console"; | |||
There was a problem hiding this comment.
Was this intentional? 🤔 I don't see it used anywhere, shall we remove it? 🙂
There was a problem hiding this comment.
I just went ahead and removed it :)
There was a problem hiding this comment.
Oh it definitely was not, thanks 😅
thepassle
reviewed
Jul 18, 2024
|
|
||
| // Return the identifier name, e.g. 'fn' in `import { fn } from 'is-boolean-object'` | ||
| // or `var fn = require('is-boolean-object')` | ||
| const identifier = |
|
LGTM! Thanks for the PR! One small comment, I think an accidental import made its way into the code. If we remove that, this is good to merge :) Nice work! |
thepassle
reviewed
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a codemod replacement for the
object-keysmodule. This is my first time writing a codemod, so let me know if there's anything I can do to improve this code.I've also added some improvements to the codebase that I think will be generally useful:
removeImportso that it will work even if the import is renamed to something than what is conventionalremoveImport