fix: import name reliance across various codemods #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeLlamoPablo
force-pushed
the
fix/import-name-on-some-mods
branch
from
d556b85 to
6deeb9d
Compare
|
This is great man, I had this on my list, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes reliance on hardcoded import names across various codemods. Developers may choose to import packages with non-standard names like
var banana = require("array-includes");in which our codemod would break the code by removing the import without replacing the usages.This PR also updates tests to ensure the "non-standard import name" case is tested. I figured I'd update the existing tests in-place, since adding new cases feels like too much overhead/boilerplate but I'm happy to make the change if you'd rather have them as separate cases.