Fix progress indicator of npm run which
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipre
force-pushed
the
fix-percentage-calculation
branch
from
6d8ddd7 to
a518964
Compare
filipre
changed the title
npm run which
|
Hehe yeah I noticed this too the other day. We also have some codemods that are not micro-utils or native/polyfills, so the numbers are skewed a bit. I think its fine to native and micro-util 👍 We can probably get rid of the script pretty soon too, since we've already implemented the bulk of them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the percentage is a bit off. The
whichscript only lists native and micro-util replacements but there are preferred replacements in the package as well which counted towards the progress. What should the percentage represent? This PR uses native and micro-util replacements only.