Add buffer-equal replacement
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Oct 15, 2024
|
The same should be added for |
I'm not seeing this package on npm. Do you have a link? |
|
Thank you! It wasn't appearing for me since it's deprecated. Yes, I agree, it should also be in here. I will add a PR for that. |
stramel
commented
Oct 16, 2024
stramel
commented
Oct 16, 2024
43081j
reviewed
Nov 11, 2024
43081j
reviewed
Nov 11, 2024
43081j
reviewed
Nov 11, 2024
stramel
force-pushed
the
patch-1
branch
2 times, most recently
from
751e2dd to
b805643
Compare
43081j
approved these changes
Nov 13, 2024
|
Build seems to fail, probably because we need to add an entry to the modules list (the readme) Looks good to me otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Please double-check this looks good, thanks!