-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more replacements: make-dir, object-keys, object-assign, readable-stream #91
Conversation
|
||
## NodeJS (since v0.9.4) | ||
|
||
If your NodeJS version is recent it is better to directly use [`stream`](https://nodejs.org/api/stream.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe makes sense to mention streams from web standards, like https://developer.mozilla.org/en-US/docs/Web/API/Streams_API ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could, but they aren't a direct alternative to NodeJS streams, they need to be converted from one to the other, no?
Still, I can add another alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. I just don't know is readable-stream
NodeJS-only package or not. If yes - it's not required, if not - I think that it should be mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4.x.x of readable-stream is a cut from Node 18. This version supports Node 12, 14, 16 and 18, as well as evergreen browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes indeed, I added an alternative for Streams API
make-dir
( Fixesmake-dir
#62 ) ( Fixesmkdirp
#37 is already fixed )object.keys
withObject.keys
(this is identical to theobject-keys
packageobject-assign
withObject.assign
(this is identical to theobject.assign
packagereadable-stream
that can be replaced bynode:stream