Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw02 fix app #2

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Hw02 fix app #2

merged 4 commits into from
Dec 21, 2023

Conversation

es-x
Copy link
Owner

@es-x es-x commented Dec 21, 2023

Домашнее задание №2 «Чиним, собираем и запускаем приложение»

Чек-лист студента (Что это?)

  • Я перечитал задание после решения. Зачем перечитывать задание?
  • Я запустил go mod tidy.
  • Приложение локально собирается
  • Линтер не выдает ошибок при локальном запуске

Критерии оценки

  • Пайплайн зелёный - 4 балла

Зачёт от 4 баллов

Олег Владимирович Евдокимов added 2 commits December 21, 2023 14:43
@es-x es-x requested a review from vladislavmass December 21, 2023 12:53
Copy link
Collaborator

@vladislavmass vladislavmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошее начало. Круто что не забыли про имя модуля в go.mod, но нужно внести еще ряд правок

hw02_fix_app/printer/pkg.go Outdated Show resolved Hide resolved
hw02_fix_app/reader/pkg.go Outdated Show resolved Hide resolved
hw02_fix_app/reader/pkg.go Outdated Show resolved Hide resolved
hw02_fix_app/reader/pkg.go Outdated Show resolved Hide resolved
hw02_fix_app/reader/pkg.go Show resolved Hide resolved
hw02_fix_app/main.go Outdated Show resolved Hide resolved
hw02_fix_app/main.go Outdated Show resolved Hide resolved
@es-x es-x requested a review from vladislavmass December 21, 2023 14:17
@es-x
Copy link
Owner Author

es-x commented Dec 21, 2023

Все замечания исправил

@es-x es-x merged commit b9b3c31 into master Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants