Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper writing #11

Merged
merged 23 commits into from
Oct 23, 2023
Merged

Paper writing #11

merged 23 commits into from
Oct 23, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jul 7, 2023

Added a first draft of the paper.

In comparison with #7 only paper\paper.md and paper\paper.bib changed.

Open TODOs

  • provide links to other implementations, could you @schuhmaj ? 🙏
  • add some references to other research using polyhedral models @schuhmaj , could you? :)
  • Update links to contribute part in readme
  • Consider going on PyPI (dedicated issue?)

For convenience, PDF from 7871eba : paper.pdf (author list outdated)

First merge #7

PS: @FG-TUM I added you to the repo and would also request your review once you accept ;)

@gomezzz gomezzz added the paper Anything related to JOSS submission label Jul 7, 2023
paper/paper.md Outdated Show resolved Hide resolved
@gomezzz gomezzz requested a review from schuhmaj July 7, 2023 09:43
Updating author list
@gomezzz gomezzz requested review from darioizzo and FG-TUM July 26, 2023 09:47
Copy link
Collaborator

@FG-TUM FG-TUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few commas, singular vs plural, and the ever-looming question: US or British English? :D

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@schuhmaj
Copy link
Collaborator

schuhmaj commented Oct 11, 2023

Changelog

  • Implements/ Addresses feedback
    • Also as reference we currently have 905 from maximally 1000 words used
  • Adds CONTRIBUTING.md
  • Improves README.md
  • Improves Example Jupyter notebook
  • Updates documentation and its links
  • Update joss-compiler workflow to incorporate git lfs content

Sorry that it took so long.


Latest PDF


@gomezzz Ready for review and for a final look before we start the process :)

paper/paper.md Show resolved Hide resolved
@schuhmaj
Copy link
Collaborator

@darioizzo @FG-TUM Many thanks for the feedback. I re-requested your feedback so that you can give a final thumps-up before we start the process (also, feel free to comment if anything is still missing :))

@schuhmaj
Copy link
Collaborator

For the logs: Go from Emmanuel & Dario via Discord.

Thus, let's merge and start the process 😃

@schuhmaj schuhmaj merged commit 9a38022 into main Oct 23, 2023
3 checks passed
@schuhmaj schuhmaj deleted the paper-writing branch October 23, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper Anything related to JOSS submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants