Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS - PRE REVIEW Changes #18

Merged
merged 2 commits into from
Oct 24, 2023
Merged

JOSS - PRE REVIEW Changes #18

merged 2 commits into from
Oct 24, 2023

Conversation

schuhmaj
Copy link
Collaborator

@schuhmaj schuhmaj commented Oct 24, 2023 •
edited
Loading

Changelog

Refers to openjournals/joss-reviews#5978

  • add DOIs as requested
  • add some URLs for papers without DOI
  • fixing a very embarrassing funny error: The paper declared a picture of 67P/Churyumov–Gerasimenko as 433 Eros. Now Eros is actually Eros (also, the number of vertices and faces are now correct)
  • Closes Update Readme #8 by adding a picture of Eros to the README.md

PDF: https://raw.githubusercontent.com/openjournals/joss-papers/joss.05978/joss.05978/10.21105.joss.05978.pdf

@schuhmaj schuhmaj added the paper Anything related to JOSS submission label Oct 24, 2023
@schuhmaj schuhmaj self-assigned this Oct 24, 2023
@schuhmaj schuhmaj requested a review from gomezzz October 24, 2023 14:56
gomezzz
gomezzz approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥔

@schuhmaj schuhmaj merged commit ebe47ec into main Oct 24, 2023
4 checks passed
@schuhmaj schuhmaj deleted the joss-pre-review branch October 24, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees

@schuhmaj schuhmaj

Labels
paper Anything related to JOSS submission
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Readme
2 participants
@schuhmaj @gomezzz