Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Bits and Pieces - Version 2.2 #31

Merged
merged 39 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
7f1e4fa
apply README.md fixes to docs
schuhmaj Mar 13, 2024
09e217c
add readthedocs yaml file
schuhmaj Mar 13, 2024
20fc259
Merge branch 'main' into joss-review
schuhmaj Mar 18, 2024
9482922
fix the docs
schuhmaj Mar 18, 2024
4ac841d
resolve unnecessary ninja dependency
schuhmaj Mar 18, 2024
ed1bedc
Merge branch 'main' into joss-review
schuhmaj Mar 18, 2024
eea4dbe
add new cube gravity test with density 42
schuhmaj Mar 18, 2024
310333a
fix pytest
schuhmaj Mar 18, 2024
fbacdf9
update DOIs in JOSS paper
schuhmaj Mar 20, 2024
94a18c6
add statement of need to the documentation
schuhmaj Mar 20, 2024
a0b178d
Merge branch 'main' into joss-review
schuhmaj Mar 25, 2024
102d520
update links to the documentation
schuhmaj Mar 25, 2024
d9fad61
apply formulation suggestions of #32
schuhmaj Mar 25, 2024
19ea015
add environment.yml for Jupyter Notebook (#33)
schuhmaj Mar 25, 2024
6b4f470
remove not required dependencies
schuhmaj Mar 25, 2024
be06023
environments for jupyter notebook
schuhmaj Mar 25, 2024
c497c61
state mesh checking to README.md
schuhmaj Mar 25, 2024
5d60f26
fix cmake generator selection
schuhmaj Mar 25, 2024
4d7d608
add badges to the docs as well
schuhmaj Mar 25, 2024
680b218
no ninja required
schuhmaj Mar 26, 2024
4f657e8
improve formatting
schuhmaj Mar 26, 2024
714bda4
improve formatting given the expected input of doxygen
schuhmaj Mar 26, 2024
5c52ed8
restructure the documentation
schuhmaj Mar 26, 2024
26102a9
highlight the utility module/ the mesh properties
schuhmaj Mar 26, 2024
d8a50fe
resolve unit confusion
schuhmaj Mar 26, 2024
e6e04e8
remove units from Eros example
schuhmaj Mar 26, 2024
622fe7f
invert acceleration; upgrade version number; update description
schuhmaj Mar 28, 2024
d4fcf9a
refactor docs
schuhmaj Mar 28, 2024
339fe8c
refactor docs
schuhmaj Mar 28, 2024
f0c2d60
highlight important points
schuhmaj Mar 28, 2024
58edd5d
update README.md
schuhmaj Mar 28, 2024
e796152
update table of contents
schuhmaj Mar 28, 2024
3f9e140
rename section
schuhmaj Mar 28, 2024
0e3c327
update README.md and docs
schuhmaj Mar 28, 2024
06eedbf
invert acceleration sign in tests
schuhmaj Mar 28, 2024
5cfac1b
handle borken Fortran link
schuhmaj Mar 28, 2024
f3da679
fix image path
schuhmaj Mar 28, 2024
2243bc5
fix the image not being displayed
schuhmaj Mar 28, 2024
2a60ca9
improve LaTeX syntax
schuhmaj Apr 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Deploy Sphinx documentation to Pages
on:
push:
branches: ["main"]
workflow_dispatch:

env:
GITHUB_PAGES_BUILD: True
Expand All @@ -21,5 +22,10 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install -y doxygen
- uses: actions/checkout@v3
with:
lfs: true
- id: deployment
uses: sphinx-notes/pages@v3
with:
checkout: false
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ All types of contributions are encouraged and valued. See the [Table of Contents

## I Have a Question

> If you want to ask a question, we assume that you have read the available [Documentation](https://polyhedral-gravity-model-cpp.readthedocs.io/en/stable/).
> If you want to ask a question, we assume that you have read the available [Documentation](https://esa.github.io/polyhedral-gravity-model/).

Before you ask a question, it is best to search for existing [Issues](https://github.com/esa/polyhedral-gravity-model/issues) that might help you. In case you have found a suitable issue and still need clarification, you can write your question in this issue. It is also advisable to search the internet for answers first.

Expand All @@ -53,7 +53,7 @@ We will then take care of the issue as soon as possible.
A good bug report shouldn't leave others needing to chase you up for more information. Therefore, we ask you to investigate carefully, collect information and describe the issue in detail in your report. Please complete the following steps in advance to help us fix any potential bug as fast as possible.

- Make sure that you are using the latest version.
- Determine if your bug is really a bug and not an error on your side e.g. using incompatible environment components/versions (Make sure that you have read the [documentation](https://polyhedral-gravity-model-cpp.readthedocs.io/en/stable/). If you are looking for support, you might want to check [this section](#i-have-a-question)).
- Determine if your bug is really a bug and not an error on your side e.g. using incompatible environment components/versions (Make sure that you have read the [documentation](https://esa.github.io/polyhedral-gravity-model/). If you are looking for support, you might want to check [this section](#i-have-a-question)).
- To see if other users have experienced (and potentially already solved) the same issue you are having, check if there is not already a bug report existing for your bug or error in the [issue board](https://github.com/esa/polyhedral-gravity-modelissues?q=label%3Abug).
- Collect information about the bug:
- OS, Platform and Version (Windows, Linux, macOS, x86, ARM)
Expand Down Expand Up @@ -89,7 +89,7 @@ This section guides you through submitting an enhancement suggestion for Polyhed
#### Before Submitting an Enhancement

- Make sure that you are using the latest version.
- Read the [documentation](https://polyhedral-gravity-model-cpp.readthedocs.io/en/stable/) carefully and find out if the functionality is already covered, maybe by an individual configuration.
- Read the [documentation](https://esa.github.io/polyhedral-gravity-model) carefully and find out if the functionality is already covered, maybe by an individual configuration.
- Perform a [search](https://github.com/esa/polyhedral-gravity-model/issues) to see if the enhancement has already been suggested. If it has, add a comment to the existing issue instead of opening a new one.
- Find out whether your idea fits with the scope and aims of the project. It's up to you to make a strong case to convince the project's developers of the merits of this feature. Keep in mind that we want features that will be useful to the majority of our users and not just a small subset. If you're just targeting a minority of users, consider writing an add-on/plugin library.

Expand All @@ -108,7 +108,7 @@ Enhancement suggestions are tracked as [GitHub issues](https://github.com/esa/po
Have you found an issue you would like to work on? Or do you have a great idea for a new feature? Here are some tips to get you started.

- Ensure that you work on a new branch for your contribution. The name does not need to follow a specific pattern, but it should be descriptive (e.g. `fix-issue-123` or `fancy-feature-xyz`).
- Make sure that you are using the latest version from `main`. Instructions on how to set up the project can be found in the [documentation](https://polyhedral-gravity-model-cpp.readthedocs.io/en/stable/) or in the [README](README.md).
- Make sure that you are using the latest version from `main`. Instructions on how to set up the project can be found in the [documentation](https://esa.github.io/polyhedral-gravity-model/) or in the [README](README.md).
- Please try to follow the existing code style and conventions.
- Please try to follow the best practices and guidelines for your code's quality and documentation. This includes writing tests for your code. We do not enforce a specific coverage, but we expect reasonable tests for new code.
- Please try to be short and concise with your commit messages. In case you want to provide more information, you can use the commit description.
Expand All @@ -117,7 +117,7 @@ If everything is set-up and your happy with your changes feel free to open a Pul

### Improving The Documentation

Enhancements to the documentation are always welcome (e.g. new examples, guides, improvement of a method's description, etc.). The documentation is located in the [docs](docs) folder. The documentation is built using [Sphinx](https://www.sphinx-doc.org/en/master/). The documentation is hosted on [ReadTheDocs](https://polyhedral-gravity-model-cpp.readthedocs.io/en/stable/).
Enhancements to the documentation are always welcome (e.g. new examples, guides, improvement of a method's description, etc.). The documentation is located in the [docs](docs) folder. The documentation is built using [Sphinx](https://www.sphinx-doc.org/en/master/). The documentation is hosted on [ReadTheDocs](https://esa.github.io/polyhedral-gravity-model/).

-------------

Expand Down
Loading
Loading