Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my sign off to the logbook #98

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

GabrielF98
Copy link

Thanks so much to all of you this is the best school I have attended.

Copy link
Contributor

@maxnoe maxnoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High, thanks, but you added many unnecessary files here. See the files tab here on github.

@GabrielF98
Copy link
Author

GabrielF98 commented Jun 17, 2021 via email

@JulienPeloton
Copy link
Contributor

Hi @GabrielF98 -- if you want to keep those files on your machine, but removing them from the index, you would use for example:

git rm --cached <unnecessary filename>

@GabrielF98
Copy link
Author

GabrielF98 commented Jun 17, 2021 via email

@JulienPeloton
Copy link
Contributor

No - you removed the change on the logbook (what is relevant), but unwanted files are still there (see the tab Files changed). You could do:

# remove from index unnecessary files
git rm --cached .DS_Store
git rm --cached  "machine-learning-1/Dimensionality Reduction.ipynb"
git rm --cached  "machine-learning-2/Validation and Optimization.ipynb"

git commit -m "remove unwanted files"

# add your contribution to the logbook (assuming you still have the changes)
git add participants_logbook.md

# commit and push
git commit -m "Add my contribution to the logbook"
git push

@GabrielF98
Copy link
Author

GabrielF98 commented Jun 17, 2021 via email

@JulienPeloton
Copy link
Contributor

No - the unwanted files are still there, and your contribution to the logbook is no more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants