Fix issue with build and deploy #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ℹ️ Modified WorkflowsThis pull request contains modified workflow files and no preview will be created. Workflow files modified:
If this is not from a trusted source, please inspect the changes for any malicious content. |
|
This should fix the GH action failure: https://github.com/esciencecenter-digital-skills/geospatial-python/actions/runs/12759005340 |
rogerkuou
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Looks good! Thanks! sorry overlooked when reviewing #129.
Just one small remark, maybe let's document this pinning somewhere (like an issue) and revisit this later (in a year)? Maybe ubuntun 24 machine will have R at that time.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Auto-generated via `{sandpaper}`
Source : 856842c
Branch : main
Author : Francesco Nattino <[email protected]>
Time : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy
Fix issue with build and deploy
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Auto-generated via `{sandpaper}`
Source : a3471f8
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-01-15 10:06:15 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 856842c
Branch : main
Author : Francesco Nattino <[email protected]>
Time : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy
Fix issue with build and deploy
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Auto-generated via `{sandpaper}`
Source : a3471f8
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-01-15 10:06:15 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 856842c
Branch : main
Author : Francesco Nattino <[email protected]>
Time : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy
Fix issue with build and deploy
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Auto-generated via `{sandpaper}`
Source : a3471f8
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-01-15 10:06:15 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 856842c
Branch : main
Author : Francesco Nattino <[email protected]>
Time : 2025-01-15 10:04:34 +0000
Message : Merge pull request #128 from esciencecenter-digital-skills/fix-build-and-deploy
Fix issue with build and deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 24 comes with no R installed, fix issues with GH action by pinning Ubuntu 22.
Applying this fix: https://github.com/carpentries/sandpaper/pull/606/files
See issue: carpentries/sandpaper#605