Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mizrahi): scrape extra info #890

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

simonlsk
Copy link

@simonlsk simonlsk commented Nov 22, 2024

Fix #784.

Changes:

  • Extract Cookie from main page request.
  • Fetch extra details request (endpoint /Online/api/OSH/getMaherBerurimSMF) if additionalTransactionInformation is true.
  • Concatenate details in txn.memo in the format field1: value1; field2: value2; ...;

Status and todos:

  • Tests passing locally.
  • Not sure about the returned memo format.
  • Check if there is a cleaner way to extract the cookie and use it in my requests.
  • Not stressed tested on many transactions.

I don't have a lot of experience with puppeteer, would love to get some inputs about the unchecked boxes.

Thanks

@baruchiro
Copy link
Collaborator

Thank you, I hope I will review it soon

@baruchiro
Copy link
Collaborator

Can I list you as a code owner for Mizrahi #830?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mizrahi: Bank Transfers not including extra details
2 participants