Components/dynamic domains #4450
Conversation
NelsonVides
force-pushed
the
xmpp_services
branch
from
d182658 to
284bd1c
Compare
Note that components might register _any_ domain, even one not necessarily provided by a static config or a dynamically configured one. Hence it makes no sense to use the subdomains registration API as it was described in a TODO in `mod_disco:get_external_components/2`. Furthermore, when it comes to discovery, we want to leave all components as discoverable, regardless of whether the component is a subdomain of a static domain as it was previously done. The code filtering out unrelated parent domains comes from long before MongooseIM 1.0.0, as well as the option to set `extra_domains` to reenable visibility.
This option was used to make discoverable components that for a user might not have been discoverable given the domain was unrelated. This was so decided over a decade ago before MongooseIM 1.0.0, but I'd judge a better solution is to leave components as either entirely discoverable or entirely hidden by default, as components are usually dynamic and at the same time fully controllable at the deployment, and we can now have an infinite amount of domains for which a component can become a subdomain and hard-coding "extra_domains" for each static or dynamic domain is not feasible.
NelsonVides
force-pushed
the
components/dynamic_domains
branch
from
60da145 to
9afc32c
Compare
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 60da145 small_tests_27 / small_tests / 60da145 small_tests_26 / small_tests / 60da145 small_tests_27_arm64 / small_tests / 60da145 ldap_mnesia_26 / ldap_mnesia / 60da145 ldap_mnesia_27 / ldap_mnesia / 60da145 internal_mnesia_27 / internal_mnesia / 60da145 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 60da145 dynamic_domains_mysql_redis_27 / mysql_redis / 60da145 pgsql_cets_27 / pgsql_cets / 60da145 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 60da145 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 60da145 mysql_redis_27 / mysql_redis / 60da145 cockroachdb_cets_27 / cockroachdb_cets / 60da145 pgsql_mnesia_26 / pgsql_mnesia / 60da145 mssql_mnesia_27 / odbc_mssql_mnesia / 60da145 pgsql_mnesia_27 / pgsql_mnesia / 60da145 |
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 9afc32c small_tests_26 / small_tests / 9afc32c small_tests_27 / small_tests / 9afc32c small_tests_27_arm64 / small_tests / 9afc32c ldap_mnesia_26 / ldap_mnesia / 9afc32c ldap_mnesia_27 / ldap_mnesia / 9afc32c dynamic_domains_mysql_redis_27 / mysql_redis / 9afc32c dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 9afc32c internal_mnesia_27 / internal_mnesia / 9afc32c dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 9afc32c pgsql_cets_27 / pgsql_cets / 9afc32c dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 9afc32c pgsql_mnesia_26 / pgsql_mnesia / 9afc32c cockroachdb_cets_27 / cockroachdb_cets / 9afc32c mssql_mnesia_27 / odbc_mssql_mnesia / 9afc32c pgsql_mnesia_27 / pgsql_mnesia / 9afc32c mysql_redis_27 / mysql_redis / 9afc32c |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/listeners #4450 +/- ##
==================================================
Coverage 85.40% 85.41%
==================================================
Files 553 553
Lines 33955 33948 -7
==================================================
- Hits 29000 28996 -4
+ Misses 4955 4952 -3 ☔ View full report in Codecov by Sentry. |
As described in commits:
Support dynamic domains for components:
Remove mod_disco extra_domains config key: