Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade amoc_rest with new openapi gens and enforce OTP27 #11

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Nov 16, 2024

I've been reworking the erlang-server generators, and now I wanted to finally use them here.

Old generators were entirely broken (basically generating code that would not even compile), and even after manual fixes it would generate code that wouldn't compile in newer versions of Erlang, so I reworked the generators. I've tested them in the generator repo extensively, so they produce compilable and runnable code that even passes dialyzer. They also upgrade the underlying OTP version to 27 to take advantage of JSON mostly.

Changes here are almost exclusively restrained to injecting the new generators.

Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@JanuszJakubiec JanuszJakubiec merged commit a1ea2bf into master Nov 26, 2024
1 check passed
@NelsonVides NelsonVides deleted the openapi_server branch November 27, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants