Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch the recommended config to flat #118

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Apr 24, 2023

This PR adds support for the new eslint config, an example:

// eslint.config.js
const pluginSecurity = require('eslint-plugin-security');

module.exports = [pluginSecurity.configs.recommended];

package.json Outdated Show resolved Hide resolved
@aladdin-add aladdin-add requested a review from nzakas April 24, 2023 02:26
Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one question.

Also, it would be helpful to include a description of the pull request. "Support eslint.config.js" doesn't adequately explain the changes you made here.

package.json Outdated Show resolved Hide resolved
@aladdin-add aladdin-add marked this pull request as draft May 1, 2023 22:57
@aladdin-add aladdin-add force-pushed the feat/new-config branch 2 times, most recently from 11aaf3d to ea48312 Compare May 4, 2023 02:30
@aladdin-add aladdin-add force-pushed the feat/new-config branch 2 times, most recently from bd3a970 to b5571a0 Compare October 16, 2023 07:46
@aladdin-add aladdin-add changed the title feat: support eslint.config.js feat!: switch the recommended config to flat Oct 16, 2023
@aladdin-add aladdin-add marked this pull request as ready for review October 16, 2023 07:49
@aladdin-add
Copy link
Contributor Author

@nzakas I've updated the title and description to be clearer. can you take another look?

notes: not sure why the pr checker does not know feat!.

Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas
Copy link
Contributor

nzakas commented Oct 16, 2023

Yeah, looks like it doesn't support that format. I don't have time to look into that right now, but if you do, please feel free.

@nzakas nzakas merged commit e20a366 into main Oct 16, 2023
9 of 10 checks passed
@nzakas nzakas deleted the feat/new-config branch October 16, 2023 15:33
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants