Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add no-duplicate-imports rule #4

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 6, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add a new no-duplicate-imports rule.

What changes did you make? (Give an overview)

  • Created no-duplicate-imports rule
  • Added tests for the rule
  • Added docs for the rule

Related Issues

Is there anything you'd like reviewers to focus on?

src/rules/no-duplicate-imports.js Outdated Show resolved Hide resolved
docs/rules/no-duplicate-imports.md Outdated Show resolved Hide resolved
docs/rules/no-duplicate-imports.md Outdated Show resolved Hide resolved
@mdjermanovic
Copy link
Member

We should also add the new rule to plugin.rules, recommended config, and README.

@mdjermanovic
Copy link
Member

We should add the rule here as well:

css/src/index.js

Lines 26 to 28 in c9424e5

rules: {
"no-empty-blocks": noEmptyBlocks,
},

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 8d4558b into main Nov 8, 2024
15 checks passed
@mdjermanovic mdjermanovic deleted the no-duplicate-imports branch November 8, 2024 07:02
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants