fix: Update types.ts for compatibility with verbatimModuleSyntax

[mrmckeb]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

After using this package in with the new verbatimModuleSyntax TypeScript compiler option, I hit the below error.

error TS1484: 'ElementNode' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.
error TS1484: 'ObjectNode' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.
...

What changes did you make? (Give an overview)

Changed to a type-only import for imports from @humanwhocodes/momoa.

Related Issues

Related to #84.

Is there anything you'd like reviewers to focus on?

Only one line changed.

[mrmckeb]

I verified this locally with pnpm patch [package], where the diff was:

diff --git a/dist/esm/types.ts b/dist/esm/types.ts
index f8dc7e1bee1a342e233c513d142aec97e08c6369..577f2229bb2d64db4868d482cb79586f350f59a1 100644
--- a/dist/esm/types.ts
+++ b/dist/esm/types.ts
@@ -14,7 +14,7 @@ import type {
 	LanguageOptions,
 	RuleDefinition,
 } from "@eslint/core";
-import {
+import type {
 	DocumentNode,
 	MemberNode,
 	ElementNode,

[nzakas]

Thanks for looking into this. It would be helpful to have a test to run in CI to validate this change. Is it possible to update typedefs.test.ts for this purpose? Or could we create a separate that is similar?

[mrmckeb]

Thanks @nzakas, I've just added a pass/fail test for one of the affected types. Please let me know if that's not what you had in mind though!

[fasttime]

I think we need to add "verbatimModuleSyntax": true to tests/types/tsconfig.json, otherwise the new test will pass even if the change in the source file is reverted.

[mrmckeb]

Thanks, updated!

[fasttime]

Note: I've changed the tag in the PR title to "fix:" because this change fixes a bug.

[fasttime]

LGTM, thanks! Leaving open for @nzakas to verify.

[nzakas]

LGTM. Thanks!