Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Convert to ESM #259

Merged
merged 10 commits into from
Jul 23, 2024
Merged

feat!: Convert to ESM #259

merged 10 commits into from
Jul 23, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 16, 2024

In preparing for renaming to @eslint/markdown, I went through and converted the plugin to ESM format. This includes:

  • Updating dependencies, including mdast-util-from-markdown, to support ESM.
  • Updating package.json to work correctly
  • Switching from nyc to c8 for code coverage
  • Updating release-please.yml to include an optional run of npm run build (in preparation for adding types)
  • Renamed lib to src to better match our newer repos
  • Renamed tests to include .test.js to make them easier to glob

Depends on #258

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
nzakas and others added 3 commits July 17, 2024 16:04
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit e0da221 into main Jul 23, 2024
11 checks passed
@mdjermanovic mdjermanovic deleted the esm branch July 23, 2024 09:00
This was referenced Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants