test: use ESLint v9 in examples #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
Jul 23, 2024
| "typescript": "^5.3.3", | ||
| "typescript-eslint": "^7.0.1" | ||
| "typescript-eslint": "8.0.0-alpha.51" |
There was a problem hiding this comment.
This is the latest prerelease. We'll need to use a prerelease version because v7 doesn't support ESLint 9. When final v8 is released, this should be changed to "^8.0.0".
mdjermanovic
commented
Jul 23, 2024
Comment on lines
14
to
18
| $ git clone https://github.com/eslint/eslint-plugin-markdown.git | ||
| $ cd eslint-plugin-markdown/examples/react | ||
| $ cd eslint-plugin-markdown | ||
| $ npm install | ||
| $ cd examples/react | ||
| $ npm test |
There was a problem hiding this comment.
It's necessary to install dependencies from the root because config uses the plugin module directly:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test examples (react and typescript) to use ESLint v9. Since this plugin now supports only ESLint >=9, it doesn't make sense to test with ESLint v8.