feat: Check messageIds in context.report() #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
I realized we could easily type check
messageId
incontext.report()
if we pass through theMessageIds
type fromRuleDefinition
, so I did that.What changes did you make? (Give an overview)
Enhancements to
RuleContext
and related types:MessageIds
toRuleContextTypeOptions
to support custom message identifiers.RuleContext
interface by usingRuleContextTypeOptions
directly.report
method inRuleContext
to includeMessageIds
in theViolationReport
type.ViolationMessage
andViolationReport
types to support customMessageIds
.MessageIds
in theRuleDefinition
context options.Test updates:
TestMessageIds
type and included it inTestRuleContext
to validate the changes in the test suite.Related Issues
Is there anything you'd like reviewers to focus on?