Add support for UDP Control Sockt for UDP tests (no use of TCP) #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidBar-On
force-pushed
the
issue-1830-UDP-Control-Socket
branch
from
8fa010c to
b2b6513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): Feature Request: Pure UDP Mode (No TCP) #1830
Brief description of code changes (suitable for use as a commit message):
Add support for using UDP Control Socket, using a new
--udp-controloption, so there is no use of TCP and iperf3 can work over firewalls, etc. that block TCP. A server using--udp-controlcan only work with clients that use this option, and visa versa. (Implementing a server that is able to receive connect requests over either TCP or UDP seems to be too complex.)The changes should not impact any functionality if the new option is not used. The only changes that are related to TCP control tests are change of few
read()toNread()to make sure read timeout mechanisms are supported. (It may be that these changes should have been done anyway.)No retry mechanisms are added for the control messages, so it may be that a test will fail because a control message was lost over the UDP socket. However, it seems that the available timeout mechanisms make sure that the server does not get stuck in such case. Also, once all test sockets are created not control message is sent until the final phase of the test.