fix(task/timer): Update to fix compilation if user disables ESP Task WDT in menuconfig #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WDT in menuconfig * Add appropriate guards around watchdog timer implementations for task and timer * Add comments indicating that the functions do nothing unless CONFIG_ESP_TASK_WDT_EN=y
|
✅Static analysis result - no issues found! ✅ |
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
…WDT in menuconfig (esp-cpp#326) * fix(task/timer): Update to fix compilation if user disables ESP Task WDT in menuconfig * Add appropriate guards around watchdog timer implementations for task and timer * Add comments indicating that the functions do nothing unless CONFIG_ESP_TASK_WDT_EN=y * update timer comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Some users / projects may want to fully disable the Task Watchdog Timer (WDT) feature at compile time. Previously, that would result in link errors when building the code due to the undefined calls to esp_wdt_* functions.
This PR fixes that issue.
How has this been tested?
Building a project which has CONFIG_ESP_TASK_WDT_EN=n.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.