Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task/timer): allow watchdog to start even if task/timer has not #329

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Remove check on is_started() in start_watchdog() for Task, Timer, and HighResolutionTimer

Motivation and Context

  • Allows users to call start_watchdog before calling start
  • Allows use of start_watchdog with oneshot HighResolutionTimers

How has this been tested?

Building and running task/example and timer/example on QtPy ESP32s3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 20, 2024
@finger563 finger563 added enhancement New feature or request tasks timer labels Sep 20, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 3da3e61 into main Sep 20, 2024
69 checks passed
@finger563 finger563 deleted the fix/hrt-watchdog branch September 20, 2024 21:27
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
…sp-cpp#329)

* feat(task/timer): allow watchdog to start even if task/timer has not

* update example to show use of start_watchdog before starting the timer, and to use it on a oneshot timer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tasks timer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant