Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): Allow Task::BaseConfig to configure run_on_core and run_on_core_non_blocking #332

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Add run_on_core* API overloads which take espp::Task::BaseConfig
  • Add const std::string &name default arguments to run_on_core* APIs

Motivation and Context

Allows more flexible configuration of the run-on-core threads and reuse of task config structures for more consistency.

How has this been tested?

Building and running task/example on a QtPy ESP32s3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 24, 2024
@finger563 finger563 added enhancement New feature or request tasks labels Sep 24, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 2ba54e5 into main Sep 24, 2024
69 checks passed
@finger563 finger563 deleted the feature/run-on-core-apis branch September 24, 2024 14:35
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant