Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_service): Update default value for vendor id source to be 0x01 (BLE SIG) since its predominantly used for ble #336

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

finger563
Copy link
Contributor

Description

Change to have BLE SIG be the default for the PnpId struct.

Motivation and Context

Given that the DeviceInfoService is used over BLE, this sets the default to be more reasonable for BLE devices.

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…o be 0x01 (BLE SIG) since its predominantly used for ble
@finger563 finger563 self-assigned this Oct 15, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 9d30976 into main Oct 15, 2024
69 checks passed
@finger563 finger563 deleted the fix/pnp-vendor-id branch October 15, 2024 19:09
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
…o be 0x01 (BLE SIG) since its predominantly used for ble (esp-cpp#336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant