feat(file_system): Allow single entry to string function #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `espp::FileSystem::file_entry_string(std::filesystem::path &path, const ListConfig &config, const std::string &prefix="")` method for external use * refactor `espp::FileSystem::list_directory(...)` to use `espp::FileSystem::file_entry_string(...)` function * Add file system PC test to ensure host-side / non ESP_PLATFORM code paths work just as well
|
✅Static analysis result - no issues found! ✅ |
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
* add `espp::FileSystem::file_entry_string(std::filesystem::path &path, const ListConfig &config, const std::string &prefix="")` method for external use * refactor `espp::FileSystem::list_directory(...)` to use `espp::FileSystem::file_entry_string(...)` function * Add file system PC test to ensure host-side / non ESP_PLATFORM code paths work just as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
espp::FileSystem::file_entry_string(std::filesystem::path &path, const ListConfig &config, const std::string &prefix="")method for external useespp::FileSystem::list_directory(...)to useespp::FileSystem::file_entry_string(...)functionMotivation and Context
How has this been tested?
file_system/exampleon a QtPy ESP32S3pc/tests/file_system.cpptest and running it on MacOSScreenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
QtPy
MacOS
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.