feat(led): Update how ISR is installed; move impl to cpp file #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make bool for isr service installed static within class, not just constructor * Add `static void uninstall_isr()` method so that users can uninstall the ISR if they want to * Update example to use logger for better output * Update example to show use of `uninstall_isr()` method * Move LED implementation to cpp file
|
✅Static analysis result - no issues found! ✅ |
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
…p#354) * Make bool for isr service installed static within class, not just constructor * Add `static void uninstall_isr()` method so that users can uninstall the ISR if they want to * Update example to use logger for better output * Update example to show use of `uninstall_isr()` method * Move LED implementation to cpp file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
static void uninstall_isr()method so that users can uninstall the ISR if they want touninstall_isr()methodMotivation and Context
Improves how LEDs can be managed and ensures that if one LED is destructed, any other LEDs can continue to function (since the fade function is still installed). The user can uninstall the ISR if necessary.
How has this been tested?
Building and running
led/exampleon M5Stack TimerCamScreenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.