Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ble_gatt_server): Update get_connected_device_{name/rssi} to take const arguments #362

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jan 24, 2025

Description

Make get_connected_device_name and get_connected_device_rssi take const parameters.

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jan 24, 2025
@finger563 finger563 added enhancement New feature or request ble gatt server labels Jan 24, 2025
@finger563 finger563 changed the title feat(ble_gatt_server): Update to use const parameters feat(ble_gatt_server): Update get_connected_device_{name/rssi} to take const arguments Jan 24, 2025
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 2c2279c into main Jan 24, 2025
69 checks passed
@finger563 finger563 deleted the feat/ble-gatt-server-const branch January 24, 2025 19:29
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble gatt server enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant