Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hid-rp): Flesh out gamepads to fill out their interfaces #381

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

finger563
Copy link
Contributor

Description

  • Add some concepts for structs to make it easier to get / set buttons with custom / user-defined structs/classes without having to subclass
  • Add more getters / setters for each Switch and Xbox
  • Add specializations to the Xbox class to explicitly match buttons for the xbox controller

Motivation and Context

Makes using the controllers (and converting between controller report types) easier / more painless

How has this been tested?

Build and run hid-rp/example
Build and run within esp-usb-ble-hid

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Add some concepts for structs to make it easier to get / set buttons with custom / user-defined structs/classes without having to subclass
* Add more getters / setters for each Switch and Xbox
* Add specializations to the Xbox class to explicitly match buttons for the xbox controller

Makes using the controllers (and converting between controller report types) easier / more painless

Build and run `hid-rp/example`
Build and run within [esp-usb-ble-hid](https://github.com/finger563/esp-usb-ble-hid)
@finger563 finger563 self-assigned this Feb 22, 2025
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 added the enhancement New feature or request label Feb 22, 2025
@finger563 finger563 merged commit 96edbbb into main Feb 22, 2025
73 checks passed
@finger563 finger563 deleted the feat/hid-rp-update branch February 22, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hid-rp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant