Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ble_gatt_server): Add (unneccessary) definitions for GenericAccessService #389

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Feb 28, 2025

Description

  • Add espp::GenericAccessService
  • Add method in BleGattServer to read remote Appearance of client
  • Update docs

Motivation and Context

Adds functionality for reading remote client info and adds some information about the BLE GAS - though its not needed for implementation.

How has this been tested?

  • Build ble_gatt_server/example

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…ssService

* Add `espp::GenericAccessService`
* Add method in `BleGattServer` to read remote `Appearance` of client
* Update docs

Adds functionality for reading remote client info and adds some information about the BLE GAS - though its not needed for implementation.

* Build `ble_gatt_server/example`
@finger563 finger563 self-assigned this Feb 28, 2025
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 9517c12 into main Feb 28, 2025
73 checks passed
@finger563 finger563 deleted the feat/ble-gas branch February 28, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant